On Tue, May 17, 2011 at 10:59:28PM +0100, Catalin Marinas wrote: > On 16 May 2011 18:26, Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> wrote: > > --- a/arch/arm/mach-omap1/time.c > > +++ b/arch/arm/mach-omap1/time.c > ... > > static inline unsigned long notrace omap_mpu_timer_read(int nr) > > { > > - volatile omap_mpu_timer_regs_t* timer = omap_mpu_timer_base(nr); > > - return timer->read_tim; > > + omap_mpu_timer_regs_t __iomem *timer = omap_mpu_timer_base(nr); > > + return readl(&timer->read_tim); > > } > > We should start using the *_relaxed() accessors a bit more to avoid > the barriers overhead in the standard I/O accessors. I thought about that, but when you look at patch 6, it'd change this. I wanted to use the same accessor here as it ends up with in patch 6. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html