> -----Original Message----- > From: Valkeinen, Tomi > Sent: Monday, May 16, 2011 12:29 PM > To: Janorkar, Mayuresh > Cc: linux-omap@xxxxxxxxxxxxxxx; K, Mythri P > Subject: RE: [PATCH v4 4/4] OMAP: DSS: Add picodlp panel driver > > On Mon, 2011-05-16 at 09:54 +0530, Janorkar, Mayuresh wrote: > > > > > -----Original Message----- > > > From: Valkeinen, Tomi > > > Sent: Thursday, May 12, 2011 8:40 PM > > > To: Janorkar, Mayuresh > > > Cc: linux-omap@xxxxxxxxxxxxxxx; K, Mythri P > > > Well, when is picodlp_i2c_remove() called? Isn't it called when the > i2c > > > client is being removed, i.e. when somebody has called > > > i2c_unregister_device()? > > > > The matching API for i2c_add_device is i2c_del_device. > > These are _driver_ functions not device. > > > And i2c_unregister_device is a matching API for i2c_new_device. > > > > i2c_del_device (a call present in picodlp_exit) would call i2c_remove > > and then i2c_remove has a call to i2c_unregister_device which would > > unregister the i2c_device. > > > > So panel_remove should also have a call to i2c_unregister_device. > > This would solve the problem. > > I believe panel_remove should be the only place to have > i2c_unregister_device. It is, as you said, counterpart of > i2c_new_device, and that is called from panel_probe. Looks fine. > > Tomi > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
