On Mon, May 16, 2011 at 12:45:58AM +0300, Vladimir Zapolskiy wrote: > This mass change continues the reduction of homogeneous data chunks > along clock definitions. No semantical difference is added in the > change. > > Signed-off-by: Vladimir Zapolskiy <vzapolskiy@xxxxxxxxx> > --- [ ... ] > +DEFINE_CLOCK_DM(gpu_fck, dpll_core_m7x2_ck, l3_gfx_clkdm, > + CLOCK_OPS_DFLT_SW(CM_GFX_GFX), > + CLOCK_CLKSEL0(sgx_clk_mux_sel, > + CM_GFX_GFX_CLKCTRL, CLKSEL_SGX_FCLK)); > Hi Vladimir , With this the rate wouldn't get initialised and it throws a warning at boot. [ 0.000000] ------------[ cut here ]------------ [ 0.000000] WARNING: at arch/arm/mach-omap2/clkt_clksel.c:194 omap2_clksel_recalc+0xd4/0xe4() [ 0.000000] clock: Could not find fieldval 1 for clock gpu_fck parent dpll_core_m7x2_ck [ 0.000000] Modules linked in: [ 0.000000] [<c005fd5c>] (unwind_backtrace+0x0/0xe4) from [<c00921b4>] (warn_slowpath_common+0x4c/0x64) [ 0.000000] [<c00921b4>] (warn_slowpath_common+0x4c/0x64) from [<c009224c>] (warn_slowpath_fmt+0x2c/0x3c) [ 0.000000] [<c009224c>] (warn_slowpath_fmt+0x2c/0x3c) from [<c0072594>] (omap2_clksel_recalc+0xd4/0xe4) [ 0.000000] [<c0072594>] (omap2_clksel_recalc+0xd4/0xe4) from [<c007712c>] (propagate_rate+0x24/0x50) [ 0.000000] [<c007712c>] (propagate_rate+0x24/0x50) from [<c0077138>] (propagate_rate+0x30/0x50) [ 0.000000] ---[ end trace 1b75b31a2719ed1c ]--- Will be fixed with this change below : - CLOCK_CLKSEL0(sgx_clk_mux_sel, + CLOCK_CLKSEL_INIT(sgx_clk_mux_sel, May be CLOCK_CLKSEL0 is not required altogether. I see it used only to initialise gpu_fck. May be can remove this. I boot tested it on 4430 sdp. FWIW , you can add Tested-by: Avinash.H.M. <avinashhm@xxxxxx> thanks, - Avinash > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
