On Wed, May 11, 2011 at 12:23:45PM +0300, Tomi Valkeinen wrote: > So how should the regulator be set up? You need to create a new regulator of some kind and then provide a way for machines to set the supply_regulator in the init_data. > I should setup a fixed regulator, which is supplied from VCXIO, and > omapdss will get its powers from this fixed regulator? Yes, and the example code I've deleted all looks about right. > static struct fixed_voltage_config omap_dss_fixed_reg_data = { > .supply_name = "what should this be?", > .init_data = &fixed_reg_init_data, > }; The supply name shold be supplied by the board - it's whatever the supply that's shared by all the regulators in the OMAP is. > static struct regulator_consumer_supply sdp4430_vcxio_supply[] = { > REGULATOR_SUPPLY("what should this be?", "reg-fixed-voltage.0"), > }; You don't need to specify a supply to hook the supplies up. This is a bit of a wart, but it's the current API - it's specified in the child regulator rather than the parent which is the other way around to consumers. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html