RE: [PATCH 4/7] OMAP: DSS: Add i2c client driver for picodlp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Valkeinen, Tomi
> Sent: Tuesday, April 19, 2011 5:12 PM
> To: Janorkar, Mayuresh
> Cc: linux-omap@xxxxxxxxxxxxxxx; K, Mythri P
> Subject: Re: [PATCH 4/7] OMAP: DSS: Add i2c client driver for picodlp
> 
> On Mon, 2011-04-18 at 11:45 +0530, Mayuresh Janorkar wrote:
> > The configurations and data transfer with picodlp panel happens through
> i2c.
> > An i2c client with name "picodlp_i2c_driver" is registered inside panel.
> >
> > Signed-off-by: Mythri P K <mythripk@xxxxxx>
> > Signed-off-by: Mayuresh Janorkar <mayur@xxxxxx>
> > Signed-off-by: Mythri P K <mythripk@xxxxxx>
> > ---
> >  drivers/video/omap2/displays/panel-picodlp.c |  130
> +++++++++++++++++++++++++-
> >  1 files changed, 126 insertions(+), 4 deletions(-)
> 
> <snip>
> 
> > @@ -65,8 +131,10 @@ static int picodlp_panel_power_on(struct
> omap_dss_device *dssdev)
> >  	msleep(675);
> >  	dssdev->state = OMAP_DSS_DISPLAY_ACTIVE;
> >
> > -	return 0;
> > +	picodlp_i2c_data =
> > +		i2c_get_clientdata(picod->picodlp_i2c_client);
> 
> This variable is not used at all.


Not in this patch but it is used in next patch.
I would add it as a part of next patch where it is used.

> 
>  Tomi
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux