On Fri, Apr 1, 2011 at 1:50 PM, Luciano Coelho <coelho@xxxxxx> wrote: > On Fri, 2011-04-01 at 12:46 +0530, Kishore Kadiyala wrote: >> On Fri, Apr 1, 2011 at 12:22 PM, Luciano Coelho <coelho@xxxxxx> wrote: >> > The order in which the MMC cards are defined in the the 4430sdp board >> > file seems to have been mistakenly reorderded as part of an unrelated >> > patch. In commit 0005ae73cfe44ee42d0be12a12cc82bf982f518e, where only >> > the dev_name was supposed to be changed, the mmc order was changed as >> > well. This caused the external SD card reader not to be recognized, >> > at least on Blaze. >> >> Both OMAP4 SDP & Blaze boards have internal eMMC as storage. >> >> Just think of some scenario as below with FS in eMMC >> [with external card recognized as mmcblk0 and eMMC as mmcblk1]: >> Booting with both external card on MMC1 and eMMC on MMC2 and having >> bootargs set to root=/dev/mmcblk1px [x= parition number]. >> Removing the external card from slot makes eMMC recognized as mmcblk0 and >> in this case kernel can't pick the file system as passed above in the bootargs. > > Yes, this makes sense. The internal eMMC should be mapped first, I > agree. > > >> So, making the permanent storage on the boards registered as first >> block device gets >> rid of the problem. > > Yes, but there is something wrong that causes the external MMC not to be > recognized at all if you map the internal MMC first. There is a bug > elsewhere that needs to be fixed before this change can be made. > > As I said, I don't know much about the OMAP MMC subsystem and I don't > have the time right now to investigate what really is wrong. That's why > I sent this patch, as quick fix (or rather getting rid of a regression). I don't see any regression with 2.6.39-rc1 on either OMAP4430SDP or Blaze, logs below: Blaze log : http://pastebin.com/mGB5uD7P SDP log : http://pastebin.com/A5uAFfsr > > Another thing is that this is a crosspatch change. It shouldn't be part > of the same patch that changes the name of the driver, since this is > totally unrelated. If you really think this needs to be done, it should > have been done in a separate patch. Agree , it went accidentally in V6. > > -- > Cheers, > Luca. > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
