* Hema Kalliguddi <hemahk@xxxxxx> [110328 23:11]: > Hi, > > >-----Original Message----- > >From: Tony Lindgren [mailto:tony@xxxxxxxxxxx] > >Sent: Tuesday, March 29, 2011 2:50 AM > >To: Hema HK > >Cc: linux-usb@xxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx > >Subject: Re: [PATCH 1/2 v2] usb: otg: OMAP4430: Fixing the > >omap4430_phy_init function > > > >* Hema HK <hemahk@xxxxxx> [110324 04:36]: > >> omap4430_phy_init() function can be called with no device pointer, > >> to powerdown the PHY during board init when USB is disabled. > >> Fix the function accordingly. > > > >This should no longer be needed after merge commit > >0df0914d414a504b975f3cc66ace0c16ef55b7f3. > > I did not get how the above commit help to fix it. Ah it's not there. Well IMHO omap4430_phy_init(dev) should not get called before dev is initialized in usb_musb_init. So it should get called only after the get_device(dev) call. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
