> -----Original Message----- > From: Tony Lindgren [mailto:tony@xxxxxxxxxxx] > Sent: Tuesday, March 29, 2011 2:20 AM > To: Santosh Shilimkar > Cc: linux-omap@xxxxxxxxxxxxxxx; khilman@xxxxxx; rnayak@xxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [pm-core][PATCH v3 01/21] OMAP4: PM: Add omap WakeupGen > module support > > * Santosh Shilimkar <santosh.shilimkar@xxxxxx> [110328 02:20]: > > --- a/arch/arm/mach-omap2/omap4-common.c > > +++ b/arch/arm/mach-omap2/omap4-common.c > > @@ -21,6 +21,7 @@ > > > > #include <mach/hardware.h> > > #include <mach/omap4-common.h> > > +#include <mach/omap-wakeupgen.h> > > > > #ifdef CONFIG_CACHE_L2X0 > > void __iomem *l2cache_base; > > @@ -41,6 +42,8 @@ void __init gic_init_irq(void) > > gic_cpu_base = ioremap(OMAP44XX_GIC_CPU_BASE, SZ_512); > > BUG_ON(!gic_cpu_base); > > > > + omap_wakeupgen_init(); > > + > > gic_init(0, 29, gic_dist_base_addr, gic_cpu_base); > > } > > Do you really need to initialize all of this that early? > Yes. It's a interrupt controller extension and needs to work together with GIC. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html