RE: [PATCH v2 1/2] isp1704_charger: allow board specific powering routine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

 > -----Original Message-----
 > From: Jokiniemi Kalle (Nokia-MS/Tampere)

<snip>

>  > > diff --git a/include/linux/power/isp1704_charger.h
 >  > b/include/linux/power/isp1704_charger.h
 >  > > new file mode 100644
 >  > > index 0000000..68096a6
 >  > > --- /dev/null
 >  > > +++ b/include/linux/power/isp1704_charger.h
 >  > > @@ -0,0 +1,29 @@
 >  > > +/*
 >  > > + * ISP1704 USB Charger Detection driver
 >  > > + *
 >  > > + * Copyright (C) 2011 Nokia Corporation
 >  > > + *
 >  > > + * This program is free software; you can redistribute it and/or modify
 >  > > + * it under the terms of the GNU General Public License as published by
 >  > > + * the Free Software Foundation; either version 2 of the License, or
 >  > > + * (at your option) any later version.
 >  > > + *
 >  > > + * This program is distributed in the hope that it will be useful,
 >  > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
 >  > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 >  > > + * GNU General Public License for more details.
 >  > > + *
 >  > > + * You should have received a copy of the GNU General Public License
 >  > > + * along with this program; if not, write to the Free Software
 >  > > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
 > USA
 >  > > + */
 >  > > +
 >  > > +
 >  > > +#ifndef __ISP1704_CHARGER_H
 >  > > +#define __ISP1704_CHARGER_H
 >  > > +
 >  > > +struct isp1704_charger_data {
 >  > > +	void		(*set_power)(bool on);
 >  > > +};
 >  > > +
 >  > > +#endif
 >  >
 >  >     There should be include/linux/platform_data/ directory now, specifically
 >  > for such headers...
 > 
 > Thanks for the pointer, I'll put it there.

There are things like msm-serial.h and tegra-usb.h there, but I'm not so convinced
that this isp1704_charger.h should be there. The isp1707 component on n900 is
a discrete chip, it's not part of the SoC, so in theory some other device or platform
could also use it as a charger. It's not even made by TI, so it's not related in that
sense to OMAP platform...

What do you think about keeping it still in /include/linux/power ?

- Kalle

 > 
 > - Kalle
 > 
 >  >
 >  > WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux