Re: [PATCH] OMAP3: l3: fix for "irq 10: nobody cared" message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Mar 26, 2011 at 2:29 AM, Omar Ramirez Luna <omar.ramirez@xxxxxx> wrote:
> If an error occurs in the L3 on any other initiator than MPU,
> the interrupt goes unhandled given that the 'base' register
> was calculated with the initialized err_base value (which
> coincidentally points to MPU) and not with the actual source
> of the error.
>
> Signed-off-by: Omar Ramirez Luna <omar.ramirez@xxxxxx>
> ---
> Âarch/arm/mach-omap2/omap_l3_smx.c | Â Â5 +++--
> Â1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_l3_smx.c b/arch/arm/mach-omap2/omap_l3_smx.c
> index 5f2da75..da917c2 100644
> --- a/arch/arm/mach-omap2/omap_l3_smx.c
> +++ b/arch/arm/mach-omap2/omap_l3_smx.c
> @@ -196,11 +196,12 @@ static irqreturn_t omap3_l3_app_irq(int irq, void *_l3)
> Â Â Â Â Â Â Â Â/* No timeout error for debug sources */
> Â Â Â Â}
>
> - Â Â Â base = ((l3->rt) + (*(omap3_l3_bases[int_type] + err_source)));
> -
> Â Â Â Â/* identify the error source */
> Â Â Â Âfor (err_source = 0; !(status & (1 << err_source)); err_source++)
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â;
> +
> + Â Â Â base = ((l3->rt) + (*(omap3_l3_bases[int_type] + err_source)));
> +
> Â Â Â Âerror = omap3_l3_readll(base, L3_ERROR_LOG);

One extra space too much.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux