RE: [PATCH v12 6/9] dmtimer: switch-over to platform device driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[...]
> > >
> > > * Tarun Kanti DebBarma <tarun.kanti@xxxxxx> [110308 15:41]:
> > > > switch-over to platform device driver through following changes:
> > > > (a) initiate dmtimer early initialization from omap2_gp_timer_init()
> > > > in timer-gp.c. This is equivalent of timer_init()->timer->init().
> > > > (b) modify plat-omap/dmtimer routines to use new register map and
> > > > platform data.
> > >
> > > This patch breaks booting for 2420 and makes boot hang early
> > > on 2430. Note that to test with omap-for-linus branch you need
> > > to disable the following in omap2plus_defconfig:
> > >
> > > CONFIG_ARCH_OMAP3
> > > CONFIG_ARCH_OMAP4
> > > CONFIG_CPU_32v6K
> > I disabled above options on omap-for-linus *WITHOUT* my patch series.
> > I am still seeing crash. Here is the log.
> > I tried on two different setups. Not sure if I am missing something.
> 
> Hmm sounds like H4 needs some attention. Can you try the following
> completely untested patch?

This works fine!
--
Tarun

> 
> Tony
> 
> From: Tony Lindgren <tony@xxxxxxxxxxx>
> Date: Thu, 10 Mar 2011 09:51:29 -0800
> Subject: [PATCH] omap: Fix H4 init_irq to not call h4_init_flash
> 
> There should be no reason to call h4_init_flash this
> early. It causes problems as things are not yet initialized.
> 
> Note: This patch has not been tested.
> 
> Not-Yet-Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
> 
> --- a/arch/arm/mach-omap2/board-h4.c
> +++ b/arch/arm/mach-omap2/board-h4.c
> @@ -299,7 +299,6 @@ static void __init omap_h4_init_early(void)
>  static void __init omap_h4_init_irq(void)
>  {
>  	omap_init_irq();
> -	h4_init_flash();
>  }
> 
>  static struct at24_platform_data m24c01 = {
> @@ -372,6 +371,7 @@ static void __init omap_h4_init(void)
>  	platform_add_devices(h4_devices, ARRAY_SIZE(h4_devices));
>  	omap2_usbfs_init(&h4_usb_config);
>  	omap_serial_init();
> +	h4_init_flash();
>  }
> 
>  static void __init omap_h4_map_io(void)
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux