RE: [PATCH v4 4/9] OMAP4 : DSS2 : HDMI: HDMI driver header file addition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: K, Mythri P
> Sent: Thursday, March 10, 2011 10:32 AM
> To: Premi, Sanjeev
> Cc: linux-omap@xxxxxxxxxxxxxxx; Valkeinen, Tomi
> Subject: Re: [PATCH v4 4/9] OMAP4 : DSS2 : HDMI: HDMI driver header file
> addition
> 

[snip]...[snip]

> >
> > [sp] Any specific reason to keep header file in separate patch?
> >
> When i had posted it earlier there were several compliants  that the
> patch is huge,
> if i include header file with the corresponding c file , and hence
> difficult to review. So it just to make
> reviewers job easy.

[sp] Final say on the issue rests with the maintainer. But it I found it
     difficult to review the .c file with when looking for structure
     definitions, members etc.

     If they were together, we wouldn't need this in a separate patch:
     [PATCH v4 7/9] OMAP4 : DSS : HDMI: Call to HDMI module init to...

~sanjeev

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux