Hi Tomi, On Wed, Mar 9, 2011 at 7:53 PM, Tomi Valkeinen <tomi.valkeinen@xxxxxx> wrote: > On Wed, 2011-03-09 at 05:45 -0600, K, Mythri P wrote: >> The panel driver(hdmi_omap4_panel.c) in omap2/dss acts as a controller >> to manage the enable and disable requests and synchronize audio and video. >> >> Signed-off-by: Mythri P K <mythripk@xxxxxx> >> --- >> drivers/video/omap2/dss/Kconfig | 8 + >> drivers/video/omap2/dss/Makefile | 1 + >> drivers/video/omap2/dss/hdmi_omap4_panel.c | 209 ++++++++++++++++++++++++++++ >> 3 files changed, 218 insertions(+), 0 deletions(-) >> create mode 100644 drivers/video/omap2/dss/hdmi_omap4_panel.c >> >> diff --git a/drivers/video/omap2/dss/Kconfig b/drivers/video/omap2/dss/Kconfig >> index 7749ddb..f66043f 100644 >> --- a/drivers/video/omap2/dss/Kconfig >> +++ b/drivers/video/omap2/dss/Kconfig >> @@ -125,4 +125,12 @@ config OMAP2_DSS_MIN_FCK_PER_PCK >> Max FCK is 173MHz, so this doesn't work if your PCK >> is very high. >> >> +config OMAP4_PANEL_HDMI >> + bool "HDMI panel support" >> + depends on OMAP2_DSS_HDMI >> + default n >> + help >> + HDMI panel. This adds the High Definition Multimedia panel. >> + See http://www.hdmi.org/ for HDMI specification. >> + >> endif >> diff --git a/drivers/video/omap2/dss/Makefile b/drivers/video/omap2/dss/Makefile >> index 5998b69..7ee4093 100644 >> --- a/drivers/video/omap2/dss/Makefile >> +++ b/drivers/video/omap2/dss/Makefile >> @@ -6,3 +6,4 @@ omapdss-$(CONFIG_OMAP2_DSS_VENC) += venc.o >> omapdss-$(CONFIG_OMAP2_DSS_SDI) += sdi.o >> omapdss-$(CONFIG_OMAP2_DSS_DSI) += dsi.o >> omapdss-$(CONFIG_OMAP2_DSS_HDMI) += hdmi.o >> +omapdss-$(CONFIG_OMAP4_PANEL_HDMI) += hdmi_omap4_panel.o > > You don't need CONFIG_OMAP4_PANEL_HDMI. In fact, you cannot have it: > hdmi.c calls the panel driver, so they must be compiled in or out > together. > > Also, as they depend on each other, adding them in patches like this > breaks compilation. Do it so that first add hdmi.c in a patch. Then > hdmi_omap4_panel.c. After those, add Kconfig and Makefile changes. This > way the kernel stays compilable, and you can still have the additions > divided into separate patches. Sure i will do that. > > Tomi > Thanks and regards, Mythri. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
