On Tue, Mar 8, 2011 at 4:39 PM, Andy Green <andy@xxxxxxxxxxx> wrote: > +/* struct omap_i2c_bus_platform_data .flags meanings */ > + > +#define OMAP_I2C_FLAG_NO_FIFO 1 Hi, Minor comment, Can you use BIT(0) for 1, BIT(1) for 2 ... BIT (8) for 0x100 > +#define OMAP_I2C_FLAG_SIMPLE_CLOCK 2 > +#define OMAP_I2C_FLAG_16BIT_DATA_REG 4 > +#define OMAP_I2C_FLAG_RESET_REGS_POSTIDLE 8 > +#define OMAP_I2C_FLAG_APPLY_ERRATA_I207 0x10 > +#define OMAP_I2C_FLAG_ALWAYS_ARMXOR_CLK 0x20 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html