On Tue, 8 Mar 2011, Andy Green wrote: > Peter Maydell noticed when running under QEMU he was getting > errors reporting 32-bit access to I2C peripheral unit registers > that are documented to be 8 or 16-bit only[1][2] > > The I2C driver is blameless as it wraps its accesses in a > function using __raw_writew and __raw_readw, it turned out it > is the hwmod stuff. > > However the hwmod code already has a flag to force a > perhipheral unit to only be accessed using 16-bit operations. > > This patch applies the 16-bit only flag to the 2430, > OMAP3xxx and OMAP44xx hwmod structs. 2420 was already > correctly marked up as 16-bit. > > The 2430 change will need testing by TI as arranged > in the comments to the previous patch version. > > When the 16-bit flag is or-ed with other flags, it is placed > first as requested in comments. > > [1] OMAP4430 Technical reference manual section 23.1.6.2 > [2] OMAP3530 Techincal reference manual section 18.6 > > Cc: patches@xxxxxxxxxx > Cc: Ben Dooks <ben-linux@xxxxxxxxx> > Reported-by: Peter Maydell <peter.maydell@xxxxxxxxxx> > Signed-off-by: Andy Green <andy.green@xxxxxxxxxx> For the OMAP2/3 hwmod data changes, makes sense to me. Acked-by: Paul Walmsley <paul@xxxxxxxxx> - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
