Re: [PATCH 0/2] omap_wdt: fix interface clock handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

On Tue, 8 Mar 2011, Paul Walmsley wrote:

> On Tue, 8 Mar 2011, Kevin Hilman wrote:
> 
> > Kalle Jokiniemi <kalle.jokiniemi@xxxxxxxxx> writes:
> > 
> > > The runtime PM does not offer enough granularity to control
> > > individual clocks separately as needed. Current pm implementation
> > > of omap_wdt blocks the CORE power domain from idling in
> > > OMAP SoC, as it keeps the interface clock of the watchdog always
> > > on. This causes severe power leakage in devices where 
> > > the omap watchdog is in active use.
> > 
> > The iclk remains active because it's in hardware-controlled
> > auto-idle mode.  
> 
> ... and we think that the interface clock never enters auto-idle because 
> the WDT doesn't SIdleAck to the PRCM until the special sequence has been 
> written to the WDT registers to disable it.  So even if its *CLKEN bits 
> are set to zero, the WDT prevents the system from going idle.

Actually, thinking about this further, I think this statement must be 
wrong.  The WDT may actually SIdleAck even when it's enabled.  Otherwise, 
how could disabling the clocks save much power?  The WDT shouldn't need 
its interface clock to be enabled in order to keep its timer ticking or to 
reset the system.  

So this first patch might not even be necessary.

Kalle, if both patches work, perhaps you might try dropping this one and 
see if the problem is still there?


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux