RE: [RFC 3/3] am35xx: pm: Hook-up with TPS65023

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Sripathy, Vishwanath
> Sent: Tuesday, March 08, 2011 6:16 PM
> To: Premi, Sanjeev; linux-omap@xxxxxxxxxxxxxxx
> Subject: RE: [RFC 3/3] am35xx: pm: Hook-up with TPS65023
> 
> > -----Original Message-----
> > From: Premi, Sanjeev [mailto:premi@xxxxxx]
> > Sent: Tuesday, March 08, 2011 5:56 PM
> > To: Sripathy, Vishwanath; linux-omap@xxxxxxxxxxxxxxx
> > Subject: RE: [RFC 3/3] am35xx: pm: Hook-up with TPS65023
> >
> > > -----Original Message-----
> > > From: Sripathy, Vishwanath
> > > Sent: Monday, March 07, 2011 10:01 PM
> > > To: Premi, Sanjeev; linux-omap@xxxxxxxxxxxxxxx
> > > Subject: RE: [RFC 3/3] am35xx: pm: Hook-up with TPS65023
> >
> > [snip]...[snip]
> >
> > > > > > From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap-
> > > > > > owner@xxxxxxxxxxxxxxx] On Behalf Of Sanjeev Premi
> > > > > > Sent: Wednesday, February 23, 2011 11:29 PM
> > > > > > To: linux-omap@xxxxxxxxxxxxxxx
> > > > > > Cc: Sanjeev Premi
> > > > > > Subject: [RFC 3/3] am35xx: pm: Hook-up with TPS65023
> > > > > >
> > > > > > Add glue logic to hook-up AM35x processors
> > > > > > with TPS65023.
> > > > > It seems that you are not really using Voltage layer for any
> > > interaction
> > > > > with TPS65023 as you are not using VP and VC. Then what is the
> > > > purpose of
> > > > > registering this PMIC with Voltage layer. I fail to understand the
> > > > purpose
> > > > > of this patch series.
> > > >
> > > > [sp] Then, can you suggest how do I get the AM35x EVM to boot?
> > Given
> > > > the
> > > >      current limitation of all voltage related data being
> "extracted"
> > > from
> > > >      the voltage layer - which expects only TWLx0y0 PMICs.
> > > Pls use regulator framework for setting the voltage for your PMIC.
> >
> > [sp] If you follow the current framework, voltage.c is ingrained with
> > OMAP3 initialization and same holds good for opp[_3xxx_data].c.
> >
> > It would have been great if current implementation allowed pluggable
> > interface to a PMIC. As it stands today, it isn't.
> Pls suggest what kind of pluggable interfaces you are looking for.
> I would expect basic PM IC initialization to be done as part of
> corresponding PMIC code and voltage layer is not the place to do PMIC
> initialization.

[sp] You seem to be missing the whole point on need of workaround.
     A walk-through in init sequence of OMAP and implicit dependencies
     with PMIC related code should help understanding it better.

     Pluggable interface is quite simple, choose TPS65023 as PMIC and
     I get NO code related to TWL4030 in my build.

     Do note that I haven't talked about voltage scaling so far. It is
     all about initial voltage settings. Hence the mention of initcalls
     earlier.

> 
> Vishwa
> >
> > Until implemented, workarounds have to be put in place to get
> > platform(s)
> > working. Though patch series is being done for AM35x with TPS65023.
> > The
> > similar workaround would be required for OMAP3 with TPS65023 (for
> > example).
> >
> > ...and I expect workaround to be simple and unobtrusive.
> >
> > See:
> > core_initcall(omap_voltage_early_init);
> > device_initcall(omap3_opp_init);
> > late_initcall(omap2_common_pm_late_init);
> >
> > ~sanjeev
> >
> > [snip]..[snip]
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux