minor comment - here and elsewhere - "OMAP", PM is a good idea to be caps even in $subject. On Wed, Mar 2, 2011 at 19:00, Lesly A M <leslyam@xxxxxx> wrote: > > Only configure sleep script when the flag is TWL4030_SLEEP_SCRIPT. > > Adding the missing brackets for fixing the issue. > > Signed-off-by: Lesly A M <leslyam@xxxxxx> > Cc: Nishanth Menon <nm@xxxxxx> > Cc: David Derrick <dderrick@xxxxxx> > Cc: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx> > --- > drivers/mfd/twl4030-power.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c > index 16422de..2c0d4d1 100644 > --- a/drivers/mfd/twl4030-power.c > +++ b/drivers/mfd/twl4030-power.c > @@ -447,12 +447,13 @@ static int __init load_twl4030_script(struct twl4030_script *tscript, > if (err) > goto out; > } > - if (tscript->flags & TWL4030_SLEEP_SCRIPT) > + if (tscript->flags & TWL4030_SLEEP_SCRIPT) { > if (order) > pr_warning("TWL4030: Bad order of scripts (sleep "\ > "script before wakeup) Leads to boot"\ > "failure on some boards\n"); > err = twl4030_config_sleep_sequence(address); > + } > out: > return err; > } > -- > 1.7.1 > Otherwise, looks fine to me. Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html