Hi Sricharan, I think you missed some of my feedbacks. >From: R, Sricharan >Sent: Wednesday, February 23, 2011 9:04 AM > >Hi Benoit, >>From: Sricharan R [mailto:r.sricharan@xxxxxx] >>Sent: Wednesday, February 23, 2011 11:09 AM >>To: Benoit Cousson; Santosh Shilimkar >>Cc: 'linux-omap@xxxxxxxxxxxxxxx'; Felipe Balbi >>Subject: RE: [PATCH 4/6] omap4: hwmod_data: Add l3 errorlog >data to hwmod >>database. >> >>Hi Benoit, >>> Texas Instruments France SA, 821 Avenue Jack Kilby, 06270 Villeneuve Loubet. 036 420 040 R.C.S Antibes. Capital de EUR 753.920 -----Original Message----- >>>From: Cousson, Benoit [mailto:b-cousson@xxxxxx] >>>Sent: Monday, February 21, 2011 8:10 PM >>>To: Shilimkar, Santosh >>>Cc: linux-omap@xxxxxxxxxxxxxxx; Balbi, Felipe; R, Sricharan >>>Subject: Re: [PATCH 4/6] omap4: hwmod_data: Add l3 errorlog data to >hwmod >>>database. >>> >>>Hi Sricharan, >>> >>>On 2/21/2011 2:46 PM, Shilimkar, Santosh wrote: >>>> From: sricharan<r.sricharan@xxxxxx> >>>> >>>> Add the error log registers, irqs of the l3 interconnect to the >>>> hwmod data. The hwmod change is aligned with Benoit Cousson. >>> >>>The change is almost aligned with Benoit Cousson :-) >>> >>>The subject should be something like: omap4: hwmod data: Add address >>>space and irq in L3 hwmod >>> >>>There is no errolog data in that patch. The changelog should >be updated >>>too. >>Ok. I will change the subject and the change log as well. > >Here is the updated patch as per your suggestion. >--------------- >[PATCH v2 4/6] omap4: hwmod_data: Add address space and irq in >L3 hwmod. > >Add the address spaces, irqs of the l3 interconnect to the >hwmod data. The >hwmod change is aligned with Benoit Cousson. > >Signed-off-by: Santosh Shilimkar <santosh.shilimkar@xxxxxx> >Signed-off-by: sricharan <r.sricharan@xxxxxx> >Tested-by: sricharan <r.sricharan@xxxxxx> >Cc: Benoit Cousson <b-cousson@xxxxxx> >--- >changed the subject line and the changelog > > arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 28 >++++++++++++++++++++++++++++ > 1 files changed, 28 insertions(+), 0 deletions(-) > >diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c >b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c >index c2806bd..95001d4 100644 >--- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c >+++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c >@@ -229,11 +229,37 @@ static struct omap_hwmod_ocp_if >omap44xx_l4_cfg__l3_main_1 = { > .user = OCP_USER_MPU | OCP_USER_SDMA, > }; > >+/* L3 target configuration and error log registers */ static struct >+omap_hwmod_irq_info omap44xx_l3_targ_irqs[] = { >+ { .irq = 9 + OMAP44XX_IRQ_GIC_START }, >+ { .irq = 10 + OMAP44XX_IRQ_GIC_START }, }; >+ >+static struct omap_hwmod_addr_space omap44xx_l3_targ_addrs[] = { should be named: +static struct omap_hwmod_addr_space omap44xx_l3_main_1_addrs[] = { + { + .pa_start = 0x44000000, + .pa_end = 0x44100000, + .flags = ADDR_TYPE_RT, + }, +}; + And that one should be separated because it belongs to l3_main_2 +static struct omap_hwmod_addr_space omap44xx_l3_main_2_addrs[] = { + { + .pa_start = 0x44800000, + .pa_end = 0x44900000, + .flags = ADDR_TYPE_RT, + }, +}; + And that one should be separated as well because it belongs to l3_main_3 static struct omap_hwmod_addr_space omap44xx_l3_main_3_addrs[] = { + { + .pa_start = 0x45000000, + .pa_end = 0x45100000, + .flags = ADDR_TYPE_RT, + }, +}; + You should thus update omap44xx_l3_main_1__l3_main_2 and omap44xx_l3_main_1__l3_main_3 as well with the proper address space. Regards, Benoit -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
