> -----Original Message----- > From: Kevin Hilman [mailto:khilman@xxxxxx] > Sent: Friday, March 04, 2011 9:42 PM > To: Santosh Shilimkar > Cc: linux-omap@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH 08/17] omap4: pm: Add GIC save/restore support > > Santosh Shilimkar <santosh.shilimkar@xxxxxx> writes: > > >> -----Original Message----- > >> From: Kevin Hilman [mailto:khilman@xxxxxx] > >> Sent: Thursday, March 03, 2011 4:00 AM > >> To: Santosh Shilimkar > >> Cc: linux-omap@xxxxxxxxxxxxxxx; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx > >> Subject: Re: [PATCH 08/17] omap4: pm: Add GIC save/restore > support > >> > >> Santosh Shilimkar <santosh.shilimkar@xxxxxx> writes: > >> > > > > [...] > > > >> > + /* > >> > + * Find out how many interrupts are supported. > >> > + * OMAP4 supports max of 128 SPIs where as GIC can > support > >> > + * up to 1020 interrupt sources. > >> > + */ > >> > + max_spi_reg = __raw_readl(gic_dist_base_addr + > GIC_DIST_CTR) & > >> 0x1f; > >> > + max_spi_irq = max_spi_reg * 32; > >> > >> Based on the spec, this should also be max'd at 1020 so you never > >> write the reserved values after 1020. > >> > > > > That's correct as per generic GIC specs. On OMAP4, the maximum > IRQs > > already fused in "DIST_CTR" bit-fields and fixed. Hence we don't > > need that additional comparison. > > > > OK, clarifiying this in the comment above would avoid confusion for > anyone looking at this code in combination with the spec. > Ok. Will update it -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
