> -----Original Message----- > From: Kevin Hilman [mailto:khilman@xxxxxx] > Sent: Thursday, March 03, 2011 3:43 AM > To: Santosh Shilimkar > Cc: linux-omap@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH 04/17] omap4: pm: Add CPUx OFF mode support > > Santosh Shilimkar <santosh.shilimkar@xxxxxx> writes: > > > This patch adds the CPU0 and CPU1 off mode support. CPUX close > switch > > s/CPUX/CPUx/ > > > retention (CSWR) is not supported by hardware design. > > > > The CPUx OFF mode isn't supported on OMAP4430 ES1.0 > > > > CPUx sleep code is common for hotplug, suspend and cpuilde. > > s/cpuilde/CPUidle/ > > > Signed-off-by: Santosh Shilimkar <santosh.shilimkar@xxxxxx> > > Reviewed-by: Kevin Hilman <khilman@xxxxxx> > > > --- Fixed all the comments on this patch. [....] > > +++ b/arch/arm/mach-omap2/sleep44xx.S [....] > > I didn't do a detailed review of the below assembly since you're > much more knowlegable there than me. > > However, will the assembly code here work in Thumb-2 mode? Dave > Martin > has been working on that for OMAP3, but we should make sure the > OMAP4 stuff is Thumb-2 ready out of the box. > The code as such builds for THUMB2 as I tried last time. At least I have tried not to break it for THUMB2 anywhere. Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
