Re: [PATCH v8 4/7] omap3: pm: TWL5030 version checking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 2, 2011 at 7:00 PM, Lesly A M <leslyam@xxxxxx> wrote:
<snip>

>  static struct device *
>  add_numbered_child(unsigned chip, const char *name, int num,
>                void *pdata, unsigned pdata_len,
> @@ -1056,6 +1114,9 @@ twl_probe(struct i2c_client *client, const struct i2c_device_id *id)
>        /* setup clock framework */
>        clocks_init(&client->dev, pdata->clock);
>
> +       /* read TWL IDCODE Register */
> +       twl_read_idcode_register();
> +

you missed check for TRITON again
BTW can you make twl_read_idcode_register static
if you are not exporting ?

@@ -1109,14 +1109,12 @@
 	} else {
 		twl_id = TWL4030_CLASS_ID;
 		twl_map = &twl4030_map[0];
+		twl_read_idcode_register();
 	}

 	/* setup clock framework */
 	clocks_init(&client->dev, pdata->clock);

-	/* read TWL IDCODE Register */
-	twl_read_idcode_register();
-
 	/* load power event scripts */
 	if (twl_has_power() && pdata->power)
 		twl4030_power_init(pdata->power);

>        /* load power event scripts */
>        if (twl_has_power() && pdata->power)
>                twl4030_power_init(pdata->power);
> diff --git a/include/linux/i2c/twl.h b/include/linux/i2c/twl.h
> index f4bd475..d3cc2ac 100644
> --- a/include/linux/i2c/twl.h
> +++ b/include/linux/i2c/twl.h
> @@ -150,7 +150,12 @@
>  #define MMC_PU                         (0x1 << 3)
>  #define MMC_PD                         (0x1 << 2)
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux