Kevin Hilman wrote, on 03/03/2011 06:29 AM:
Nishanth Menon<nm@xxxxxx> writes:
Kevin Hilman wrote, on 03/03/2011 05:45 AM:
Nishanth Menon<nm@xxxxxx> writes:
We will enable and disable interrupt on a need basis in the class
driver. we need to keep the irq disabled by default else the
forceupdate or vcbypass events could trigger events that we dont
need/expect to handle.
It's not clear from the patch where the IRQ is re-enabled. For example,
without knowing better, I would expect a corresponding change to the
Class 3 driver to enable/disable the IRQ as needed.
Why would that be?
a) class 3 driver does not request for any notifiers
b) class 3 does'nt need interrupts.
c) each class driver can choose to enable when it needs it - class3 does'nt.
is it fine if I add a "this is a preperation for class drivers such as
class 2 and class 1.5 which would need to use interrupts" in commit
message?
Yes, also stating/summarizing that existing class driver (e.g. class 3)
does not use interrupts would be helpful.
Ack. will do in v3.
--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
