Re: [PATCH] cbus-retu: Add locking around register access in irq handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Felipe Balbi <balbi@xxxxxx> [110228 11:07]:
> On Mon, Feb 28, 2011 at 05:06:08PM +0100, Michael Buesch wrote:
> > This adds locking around the register access in the
> > interrupt service routine.
> > 
> > Signed-off-by: Michael Buesch <mb@xxxxxxxxx>
> > Reported-by: Felipe Balbi <balbi@xxxxxx>
> 
> Fine by me. Tony, you can apply.

Only applied the first two to add the register defines because of:

BUG: sleeping function called from invalid context at kernel/mutex.c:278
in_atomic(): 1, irqs_disabled(): 0, pid: 0, name: swapper
INFO: lockdep is turned off.
[<c0063c24>] (unwind_backtrace+0x0/0xec) from [<c0402f98>] (mutex_lock_nested+0x24/0x340)
[<c0402f98>] (mutex_lock_nested+0x24/0x340) from [<c032b4e4>] (retu_write_reg+0x20/0x3c)
[<c032b4e4>] (retu_write_reg+0x20/0x3c) from [<c032bc4c>] (_retu_modify_counter+0x28/0x34)
[<c032bc4c>] (_retu_modify_counter+0x28/0x34) from [<c032be48>] (retu_wdt_set_ping_timer+0x10/0x50)
[<c032be48>] (retu_wdt_set_ping_timer+0x10/0x50) from [<c00a2000>] (run_timer_softirq+0x260/0x368)
[<c00a2000>] (run_timer_softirq+0x260/0x368) from [<c009bdb8>] (__do_softirq+0xe8/0x1e0)
[<c009bdb8>] (__do_softirq+0xe8/0x1e0) from [<c009bf04>] (irq_exit+0x54/0xa0)
[<c009bf04>] (irq_exit+0x54/0xa0) from [<c0052090>] (asm_do_IRQ+0x90/0xcc)
[<c0052090>] (asm_do_IRQ+0x90/0xcc) from [<c0404adc>] (__irq_svc+0x3c/0x100)

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux