On Tue, 2011-03-01 at 08:16 -0600, K, Mythri P wrote: > Adding the hdmi interface driver header file (hdmi.h) to the dss driver. > Register and timing declaration to be used by the corresponding c file > is added in this file. > > Signed-off-by: Mythri P K <mythripk@xxxxxx> > --- > drivers/video/omap2/dss/hdmi.h | 597 ++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 597 insertions(+), 0 deletions(-) > create mode 100644 drivers/video/omap2/dss/hdmi.h This file is dss internal header. How will the audio side be handled? Does the audio driver need something from here? If so, those things should be somewhere else. Some or many of the structs/enums in this file are not used currently. It would make reviewing and understanding the code much easier, if things would be added only when they are actually used. Can you go through them and leave only the things that are needed for the current driver. Tomi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html