Re: [PATCH] cbus-retu: Fix nested IRQ handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2011-02-28 at 10:36 +0200, Felipe Balbi wrote: 
> On Sun, Feb 27, 2011 at 06:17:01PM +0100, Michael Buesch wrote:
> > handle_nested_irq() expects a global IRQ number, so
> > the irq_base has to be added to the RETU irq number.
> > 
> > Signed-off-by: Michael Buesch <mb@xxxxxxxxx>
> 
> Good catch, while at that, could you also cook another patch to add
> locking on retu_irq_handler ? We are using the internal lockless
> version of the read/write functions, so we need to hold the mutex before
> reading/writing to avoid problems.

Ok, it probably is safe without locking (due to the reads being atomic),
but I agree that it's more robust to add some locking here. I'll send
a patch.

-- 
Greetings Michael.

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux