On Mon, Feb 28, 2011 at 4:34 PM, Manuel, Lesly Arackal <leslyam@xxxxxx> wrote:
> Hi Balaji,
>
> On Mon, Feb 28, 2011 at 12:54 PM, Krishnamoorthy, Balaji T
> <balajitk@xxxxxx> wrote:
>> On Sat, Feb 26, 2011 at 5:55 PM, Lesly A M <leslyam@xxxxxx> wrote:
>>
>> Minor comment you missed version number in subject.
>>
>> <snip>
>>
>>> +/**
>>> + * twl_get_si_type - api to get TWL Si type.
>>> + *
>>> + * Api to get the TWL Si type from IDCODE value.
>>> + */
>>> +int twl_get_si_type(void)
>>> +{
>>> + return TWL_SIL_TYPE(twl_idcode);
>>> +}
>>> +EXPORT_SYMBOL(twl_get_si_type);
>>> +
>>> +/**
>>> + * twl_get_si_version - api to get TWL Si version.
>>> + *
>>> + * Api to get the TWL Si version from IDCODE value.
>>> + */
>>> +int twl_get_si_version(void)
>>> +{
>>> + return TWL_SIL_REV(twl_idcode);
>>> +}
>>> +EXPORT_SYMBOL(twl_get_si_version);
>>> +
>>> static struct device *
>>> add_numbered_child(unsigned chip, const char *name, int num,
>>> void *pdata, unsigned pdata_len,
>>> @@ -1056,6 +1114,12 @@ twl_probe(struct i2c_client *client, const struct i2c_device_id *id)
>>> /* setup clock framework */
>>> clocks_init(&client->dev, pdata->clock);
>>>
>>> + /* read TWL IDCODE Register */
>>> + if (twl_read_idcode_register(&twl_idcode)) {
>>
>> Call this function only in case of Triton
>
> How do I check it ?
> using if (twl_id == TWL4030_CLASS_ID)
yes
>
>>
>>> + pr_err("TWL4030 Unable to read IDCODE Register\n");
>>> + return -EIO;
>>
>> Do you really want to fail twl_probe due to error in reading IDCODE ?
>
> Is the twl_probe function expected to continue, if the i2c read/write
> on twl itself is failing ?
I don't want to fail twl_probe completely due to one occasional i2c failures.
Even this pr_err is not needed as you do that inside
twl_read_idcode_register
>
> Regards,
> Lesly A M
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
