Hi Tomi,
On Sun, Feb 27, 2011 at 2:43 PM, Tomi Valkeinen <tomi.valkeinen@xxxxxx> wrote:
> On Fri, 2011-02-25 at 08:21 -0600, K, Mythri P wrote:
>> Adding board file changes for display which adds the display structure
>> with HDMI as the default driver when the display init is called.
>> HDMI GPIO configurations are also done in this file.
>>
>> Signed-off-by: Mythri P K <mythripk@xxxxxx>
>> ---
>> arch/arm/mach-omap2/board-4430sdp.c | 82 +++++++++++++++++++++++++++++++++++
>> 1 files changed, 82 insertions(+), 0 deletions(-)
>
> You could move this patch in the end of the set, together with the panda
> board patch.
>
> The prefix "OMAP4: DSS2" is not quite right for this, as this is a board
> file change. And you should mention HDMI in the subject. Perhaps
> something like "OMAP: 4430SDP: Add HDMI support"
>
Sure i will move and change the patch name.
>>
>> diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c
>> index 07d1b20..334b6fd 100644
>> --- a/arch/arm/mach-omap2/board-4430sdp.c
>> +++ b/arch/arm/mach-omap2/board-4430sdp.c
>> @@ -35,6 +35,7 @@
>> #include <plat/common.h>
>> #include <plat/usb.h>
>> #include <plat/mmc.h>
>> +#include <plat/display.h>
>>
>> #include "mux.h"
>> #include "hsmmc.h"
>> @@ -47,6 +48,8 @@
>> #define OMAP4SDP_MDM_PWR_EN_GPIO 157
>> #define OMAP4_SFH7741_SENSOR_OUTPUT_GPIO 184
>> #define OMAP4_SFH7741_ENABLE_GPIO 188
>> +#define HDMI_GPIO_HPD 60 /* Hot plug pin for HDMI */
>> +#define HDMI_GPIO_LS_OE 41 /* Level shifter for HDMI */
>>
>> static struct gpio_led sdp4430_gpio_leds[] = {
>> {
>> @@ -552,6 +555,84 @@ static void __init omap_sfh7741prox_init(void)
>> }
>> }
>>
>> +static void sdp4430_hdmi_mux_init(void)
>> +{
>> + /* PAD0_HDMI_HPD_PAD1_HDMI_CEC */
>> + omap_mux_init_signal("hdmi_hpd",
>> + OMAP_PIN_INPUT_PULLUP);
>> + omap_mux_init_signal("hdmi_cec",
>> + OMAP_PIN_INPUT_PULLUP);
>> + /* PAD0_HDMI_DDC_SCL_PAD1_HDMI_DDC_SDA */
>> + omap_mux_init_signal("hdmi_ddc_scl",
>> + OMAP_PIN_INPUT_PULLUP);
>> + omap_mux_init_signal("hdmi_ddc_sda",
>> + OMAP_PIN_INPUT_PULLUP);
>> +}
>> +
>> +static int sdp4430_panel_enable_hdmi(struct omap_dss_device *dssdev)
>> +{
>> + int status;
>
> r is quite often used as a name for return values.
>
Variable status is consistent with other gpio request calls made in the file ,
so it would be good to have status instead of r ,
I have used r in all DSS files though.
>> +
>> + status = gpio_request_one(HDMI_GPIO_HPD, GPIOF_DIR_OUT,
>> + "hdmi_gpio_hpd");
>> + if (status) {
>> + pr_err("Cannot request GPIO %d\n", HDMI_GPIO_HPD);
>> + return status;
>> + }
>> + status = gpio_request_one(HDMI_GPIO_LS_OE, GPIOF_DIR_OUT,
>> + "hdmi_gpio_ls_oe");
>> + if (status) {
>> + pr_err("Cannot request GPIO %d\n", HDMI_GPIO_LS_OE);
>> + goto error1;
>> + }
>> +
>> + /* The value set a pulse */
>
> I still don't understand that comment. It's not even English.
I was seeing issues where I had to set the pulse [ 101] , But i no
longer see the problem in my tests.
So i shall just enable GPIO.
>
> Tomi
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
