On Thu, Feb 24, 2011 at 9:00 AM, Grant Likely <grant.likely@xxxxxxxxxxxx> wrote: > On Thu, Feb 24, 2011 at 04:13:31PM +0200, Hannu Heikkinen wrote: >> Off-by-one error, gave erroneous divisor value 16 if speed_hz is over zero but >> less than OMAP2_MCSPI_MAX_FREQ / (1 << 15), that is, [1..1463]. >> >> Also few overly complex bit shifts in divisor fixed. >> >> Also one dev_dgb line fixed, which indicated max speed exceeding transfer speed. >> >> Introducing a new function omap2_mcspi_calc_divisor() for getting the right >> divisor in omap2_mcspi_setup_transfer(). >> >> Signed-off-by: Phil Carmody <ext-phil.2.carmody@xxxxxxxxx> >> Signed-off-by: Hannu Heikkinen <ext-hannu.m.heikkinen@xxxxxxxxx> > > Applied, thanks Patch adds a build warning: CC drivers/spi/omap2_mcspi.o linux-2.6/drivers/spi/omap2_mcspi.c: In function 'omap2_mcspi_setup_transfer': linux-2.6/drivers/spi/omap2_mcspi.c:687: warning: comparison of distinct pointer types lacks a cast I've dropped it, please fix up and resubmit. Thanks, g. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
