gpio126: Multiple gpio paths (2) : CAM_STROBE & SDMMC1_DAT4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



There is this boot-time message on the am3517evm (and possibly 
other omap 35xx based boards as well)
[    0.000000] _omap_mux_init_gpio: Multiple gpio paths
 (2) for gpio126
I realized that this happens due to dual mappings for gpio_126 in arch/arm/mach-omap2/mux34xx.c:

static struct omap_mux __initdata omap3_muxmodes[] = {
:
_OMAP3_MUXENTRY(CAM_STROBE, 126,
                "cam_strobe", NULL, NULL, NULL,
                "gpio_126", "hw_dbg11", NULL, "safe_mode"),
:
_OMAP3_MUXENTRY(SDMMC1_DAT4, 126,
                "sdmmc1_dat4", NULL, "sim_io", NULL,
                "gpio_126", NULL, NULL, "safe_mode"),
:
#if defined(CONFIG_OMAP_MUX) && defined(CONFIG_OMAP_PACKAGE_CBB) static struct omap_mux __initdata omap3_cbb_subset[] = {
:
       _OMAP3_MUXENTRY(CAM_STROBE, 126,
                "cam_strobe", NULL, NULL, NULL,
                "gpio_126", NULL, NULL, "safe_mode"),

Removing one instance of CAM_STROBE from omap3_muxmodes rids us
of this (pr_info) message and should be fine as this is defined in 
omap3_xxx_subset as well. But I'm concerned if this would break things 
on the other omap3 boards?

For completeness, I've listed my patch (only for the CBB package) below 
(this also modifies the Mode 5 value of CAM_STROBE from NULL to hw_dbg11
in omap3_cbb_subset, which is incorrect right now); please comment:

---
 arch/arm/mach-omap2/mux34xx.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/arch/arm/mach-omap2/mux34xx.c b/arch/arm/mach-omap2/mux34xx.c index 440c98e..2517141 100644
--- a/arch/arm/mach-omap2/mux34xx.c
+++ b/arch/arm/mach-omap2/mux34xx.c
@@ -86,9 +86,6 @@ static struct omap_mux __initdata omap3_muxmodes[] = {
 	_OMAP3_MUXENTRY(CAM_PCLK, 97,
 		"cam_pclk", NULL, NULL, NULL,
 		"gpio_97", "hw_dbg2", NULL, "safe_mode"),
-	_OMAP3_MUXENTRY(CAM_STROBE, 126,
-		"cam_strobe", NULL, NULL, NULL,
-		"gpio_126", "hw_dbg11", NULL, "safe_mode"),
 	_OMAP3_MUXENTRY(CAM_VS, 95,
 		"cam_vs", NULL, NULL, NULL,
 		"gpio_95", "hw_dbg1", NULL, "safe_mode"), @@ -1299,7 +1296,7 @@ static struct omap_mux __initdata omap3_cbb_subset[] = {
 		"gpio_97", NULL, NULL, "safe_mode"),
 	_OMAP3_MUXENTRY(CAM_STROBE, 126,
 		"cam_strobe", NULL, NULL, NULL,
-		"gpio_126", NULL, NULL, "safe_mode"),
+		"gpio_126", "hw_dbg11", NULL, "safe_mode"),
 	_OMAP3_MUXENTRY(CAM_VS, 95,
 		"cam_vs", NULL, NULL, NULL,
 		"gpio_95", NULL, NULL, "safe_mode"),
--
1.6.2.4
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux