Re: [PATCH v8 3/3] OMAP4:keypad: PM runtime

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Dmitry,
If there are no further comments.
Can it be queued?

With Regards,
Shubhro

On Tuesday 08 February 2011 02:00 PM, Shubhrajyoti wrote:
Hello,
Any comments/suggestions.

Thanks,

On Monday 27 December 2010 11:21 AM, shubhrajyoti@xxxxxx wrote:
From: Abraham Arce<x0066660@xxxxxx>

Enable Runtime PM functionality in OMAP4 driver based on the following assumptions

A minimal pm runtime get/put approach is implemented in probe/remove calls
respectively.

- Keyboard controller in wakeup domain so it is always on and
   power impact may be minimal
- In OMAP4 the device control is at module/device level and ick/fclk level control is
   difficult so cutting of clocks will prevent interrupts.

Signed-off-by: Abraham Arce<x0066660@xxxxxx>
Cc: Kevin Hilman<khilman@xxxxxxxxxxxxxxxxxxx>
Signed-off-by: Shubhrajyoti D<shubhrajyoti@xxxxxx>
---
  drivers/input/keyboard/omap4-keypad.c |    8 ++++++++
  1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard/omap4-keypad.c
index 45bd097..fcfbb9b 100644
--- a/drivers/input/keyboard/omap4-keypad.c
+++ b/drivers/input/keyboard/omap4-keypad.c
@@ -29,6 +29,7 @@
  #include<linux/io.h>
  #include<linux/input.h>
  #include<linux/slab.h>
+#include<linux/pm_runtime.h>

  #include<plat/omap4-keypad.h>

@@ -239,6 +240,9 @@ static int __devinit omap4_keypad_probe(struct platform_device *pdev)
      matrix_keypad_build_keymap(pdata->keymap_data, row_shift,
              input_dev->keycode, input_dev->keybit);

+    pm_runtime_enable(&pdev->dev);
+    pm_runtime_get_sync(&pdev->dev);
+
      omap4_keypad_config(keypad_data);

      error = request_irq(keypad_data->irq, omap4_keypad_interrupt,
@@ -278,6 +282,10 @@ static int __devexit omap4_keypad_remove(struct platform_device *pdev)
      struct resource *res;

      free_irq(keypad_data->irq, keypad_data);
+
+    pm_runtime_put_sync(&pdev->dev);
+    pm_runtime_disable(&pdev->dev);
+
      input_unregister_device(keypad_data->input);

      iounmap(keypad_data->base);


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux