> -----Original Message----- > From: Paul Walmsley [mailto:paul@xxxxxxxxx] > Sent: Friday, February 11, 2011 10:44 AM > To: Rajendra Nayak > Cc: linux-omap@xxxxxxxxxxxxxxx; Kevin Hilman; Benoit Cousson; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: RE: [PATCH 3/3] OMAP4: clockdomain: Add wkup/sleep dependency support > > Hi Rajendra > > On Fri, 11 Feb 2011, Rajendra Nayak wrote: > > > Failing silently is going to make it more difficult to identify and fix. > > Maybe a WARN in else? > > > > if (cd->clkdm) { > > ... > > } else > > WARN() > > I was thinking it might be nice to put it right next to the > _clkdm_lookup()s in clkdm_init(), since the _clkdm_lookup is what is > actually failing. Then we could do a > > if (!cd->clkdm) > continue; > > in the SoC-specific *_all_wkdep/sleepdep* code, just to keep the system > from crashing... > > Does that sound okay to you? Yep, that sounds better. Thanks, Rajendra > > > - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
