Vishwanath Sripathy <vishwanath.bs@xxxxxx> writes:
[...]
>> > + * This is a fundamental structure used to store all the required
>> > + * DVFS related information for a vdd.
>> > + */
>> > +struct omap_vdd_dvfs_info {
>> > + spinlock_t user_lock; /* spin lock */
>>
>> comment redundant
>>
>
> I added this because checkpatch was giving a warning saying mutex added
> w/o comments.
>
The point of the checkpatch warning is not to add just any comment. The
point is to add a *useful* comment.
It is extremely helpful to readers of code with locking to know what the
locks are intended to protect. The comment should indicate what the
lock is protecting and why.
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
