> -----Original Message----- > From: Kevin Hilman [mailto:khilman@xxxxxx] > Sent: Friday, February 04, 2011 9:36 PM > To: Vishwanath BS > Cc: linux-omap@xxxxxxxxxxxxxxx; patches@xxxxxxxxxx; Thara Gopinath > Subject: Re: [PATCH 06/13] OMAP: Disable Smartreflex across DVFS > > Vishwanath BS <vishwanath.bs@xxxxxx> writes: > > > From: Thara Gopinath <thara@xxxxxx> > > > > This patch disables smartreflex for a particular voltage > > domain when the the voltage domain and the devices belonging > > to it is being scaled and re-enables it back once the scaling > > is done. > > Should also describe why. > > > Signed-off-by: Thara Gopinath <thara@xxxxxx> > > Signed-off-by: Vishwanath BS <vishwanath.bs@xxxxxx> > > --- > > arch/arm/mach-omap2/dvfs.c | 7 +++++++ > > 1 files changed, 7 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm/mach-omap2/dvfs.c b/arch/arm/mach- > omap2/dvfs.c > > index 05a9ce3..1e5492c 100755 > > --- a/arch/arm/mach-omap2/dvfs.c > > +++ b/arch/arm/mach-omap2/dvfs.c > > @@ -529,6 +529,9 @@ static int omap_dvfs_voltage_scale(struct > omap_vdd_dvfs_info *dvfs_info) > > > > curr_volt = omap_voltage_get_nom_volt(voltdm); > > > > + /* Disable smartreflex module across voltage and frequency > scaling */ > > comment redundant > > > + omap_sr_disable(voltdm); > > + > > if (curr_volt == volt) { > > is_volt_scaled = 1; > > } else if (curr_volt < volt) { > > @@ -536,6 +539,7 @@ static int omap_dvfs_voltage_scale(struct > omap_vdd_dvfs_info *dvfs_info) > > if (ret) { > > pr_warning("%s: Unable to scale the %s to %ld > volt\n", > > __func__, voltdm->name, > volt); > > + omap_sr_enable(voltdm); > > Would probably be cleaner to make this error path 'goto' the end where > the SR enable and mutex_unlock are already being done. Dependency vdd handing is not required in this case and if I use goto, then I cannot skip dependency handling since it is done after unlocking mutex. > > > mutex_unlock(&dvfs_info->scaling_mutex); > > return ret; > > } > > @@ -570,6 +574,9 @@ static int omap_dvfs_voltage_scale(struct > omap_vdd_dvfs_info *dvfs_info) > > if (!is_volt_scaled && !ret) > > omap_voltage_scale_vdd(voltdm, volt); > > > > + /* Enable Smartreflex module */ > > comment redundant ok Vishwa > > > + omap_sr_enable(voltdm); > > + > > mutex_unlock(&dvfs_info->scaling_mutex); > > > > /* calculate the voltages for dependent vdd's */ > > Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
