Vishwanath BS <vishwanath.bs@xxxxxx> writes:
> There could be dependencies between various voltage domains for
> maintaining system performance or hardware limitation reasons
> like VDD<X> should be at voltage v1 when VDD<Y> is at voltage v2.
> This patch introduce dependent vdd information structures in the
> voltage layer which can be used to populate these dependencies
> for a voltage domain. This patch also adds support to scale
> the dependent vdd and the scalable devices belonging to it
> during the scaling of a main vdd through omap_voltage_scale.
>
> As part of this, some of the voltage layer structure definitions are moved from
> voltage.c to voltage.h as it needs to be used in the dvfs layer for dependency
> voltage handling.
IMO, it would be cleaner to keep this in the voltage layer, and create
and API for dependencies.
> Based on original patch from Thara.
>
> Signed-off-by: Vishwanath BS <vishwanath.bs@xxxxxx>
> Cc: Thara Gopinath <thara@xxxxxx>
> ---
> arch/arm/mach-omap2/dvfs.c | 87 +++++++++++++++++
> arch/arm/mach-omap2/voltage.c | 117 -----------------------
> arch/arm/plat-omap/include/plat/voltage.h | 148 +++++++++++++++++++++++++++++
> 3 files changed, 235 insertions(+), 117 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/dvfs.c b/arch/arm/mach-omap2/dvfs.c
> index cefc2be..c9d3894 100755
> --- a/arch/arm/mach-omap2/dvfs.c
> +++ b/arch/arm/mach-omap2/dvfs.c
> @@ -85,6 +85,7 @@ struct omap_vdd_dvfs_info {
> struct mutex scaling_mutex; /* dvfs mutex */
> struct voltagedomain *voltdm;
> struct list_head dev_list;
> + struct device vdd_device;
It's not clear what the usage of this device is for.
It is never initialized, but seems to be used as a dummy device when
calcluating dependencies. Needs clarification.
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
