> -----Original Message----- > From: Dave Martin [mailto:dave.martin@xxxxxxxxxx] > Sent: Wednesday, December 08, 2010 4:35 PM > To: Santosh Shilimkar > Cc: Tony Lindgren; linux-omap@xxxxxxxxxxxxxxx; linaro- > dev@xxxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH v2 2/3] ARM: omap4: Correct definition of do_wfi() > forCONFIG_THUMB2_KERNEL > > On Wed, Dec 8, 2010 at 10:45 AM, Santosh Shilimkar > <santosh.shilimkar@xxxxxx> wrote: > >> -----Original Message----- > >> From: Dave Martin [mailto:dave.martin@xxxxxxxxxx] > >> Sent: Wednesday, December 08, 2010 4:11 PM > >> To: Santosh Shilimkar > >> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Tony Lindgren; linux- > >> omap@xxxxxxxxxxxxxxx; linaro-dev@xxxxxxxxxxxxxxxx > >> Subject: Re: [PATCH v2 2/3] ARM: omap4: Correct definition of do_wfi() > >> forCONFIG_THUMB2_KERNEL > >> > >> On Wed, Dec 8, 2010 at 5:59 AM, Santosh Shilimkar > >> <santosh.shilimkar@xxxxxx> wrote: > >> > Dave, > >> > > >> >> -----Original Message----- > >> >> From: Santosh Shilimkar [mailto:santosh.shilimkar@xxxxxx] > >> >> Sent: Wednesday, December 08, 2010 11:27 AM > >> >> To: Dave Martin > >> >> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Tony Lindgren; linux- > >> >> omap@xxxxxxxxxxxxxxx; linaro-dev@xxxxxxxxxxxxxxxx > >> >> Subject: RE: [PATCH v2 2/3] ARM: omap4: Correct definition of > > do_wfi() > >> >> forCONFIG_THUMB2_KERNEL > >> >> > >> >> > -----Original Message----- > >> >> > From: Dave Martin [mailto:dave.martin@xxxxxxxxxx] > >> >> > Sent: Tuesday, December 07, 2010 10:21 PM > >> >> > To: Santosh Shilimkar > >> >> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Tony Lindgren; linux- > >> >> > omap@xxxxxxxxxxxxxxx; linaro-dev@xxxxxxxxxxxxxxxx > >> >> > Subject: Re: [PATCH v2 2/3] ARM: omap4: Correct definition of > >> do_wfi() > >> >> > forCONFIG_THUMB2_KERNEL > >> >> > > >> >> > Hi, > >> >> > > >> >> > On Tue, Dec 7, 2010 at 6:28 AM, Santosh Shilimkar > >> >> > <santosh.shilimkar@xxxxxx> wrote: > >> >> > > Dave, > >> > > >> > [.....] > >> >> > >> >> > So anything inside #ifdef CONFIG_THUMB2_KERNEL can assume > > v7/Thumb-2 > >> >> > capable (and hence reasonably new) tools. > >> >> > > >> >> > I'll follow up shortly with a patch to the generic ARM Kconfig to > >> make > >> >> > this explicit, so that ARCH_OMAP2 and THUMB2_KERNEL can't > >> accidentally > >> >> > be configured together. > >> >> > > >> >> sure > >> > > >> > When you are doing the changes can you please check if you could > build > >> > the THUMB2 kernel with omap2plus_defconfig. I suspect the build will > >> > fail. > >> > >> With my Kconfig patch, kconfig won't let you turn on Thumb-2 in that > >> configuration: > >> > >> > > > http://lists.arm.linux.org.uk/lurker/message/20101207.165737.0897658f.en.h > >> tml > >> > >> If you want to turn on Thumb-2, you must disable ARCH_OMAP2 first. If > >> my understanding is correct, this is the right behaviour. > >> > >> > > Ofcourse it will build with ARCH_OMAP2 disabled :) (ARMv6 dependency) > > In other words, I wanted to say that "omap2plus_defconfig" can't > > be used as is to build THUMB kernel binary. > > Well, yes, that's another way of looking at it. Anyway, I think this > is the intended result -- is it OK for you? > Should be ok considering you can't do much with it. But I let Tony comment on it. Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
