Tony, On Wed, Dec 8, 2010 at 04:53, Tony Lindgren <tony@xxxxxxxxxxx> wrote: > * Tony Lindgren <tony@xxxxxxxxxxx> [101204 13:16]: >> * Varadarajan, Charulatha <charu@xxxxxx> [101202 06:08]: >> > On Thu, Dec 2, 2010 at 15:28, Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> wrote: >> > >> > > >> > > Tony, you can also add >> > > >> > > Acked-by: Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> >> >> OK, updated. Also made one more GPIO patch to allow us to deal >> with the 7xx vs 15xx/16xx MPUIO registers. Thanks for this patch which uses bank stride for OMAP1 MPUIO GPIO. This would be very helpful while doing GPIO driver cleanup. Thanks, V Charulatha > > Turns out that broke drivers/mtd/nand/ams-delta.c as it directly uses > multiple lines in parallel. So let's use 15xx/16xx offsets instead > and divide them by two. > > Regards, > > Tony > > > From: Tony Lindgren <tony@xxxxxxxxxxx> > Date: Sat, 4 Dec 2010 12:39:43 -0800 > Subject: [PATCH] omap1: Fix gpio mpuio bank to work for multi-omap for 7xx/15xx/16xx > > We need to divide the 15xx/16xx offset by 2 for 7xx. Use bank->stride > for that. This allows us to get rid of the duplicate defines for the > MPUIO registers. > > Note that this will cause omap-keypad.c driver to not work on 7xx. > However, the right fix there is to move over to gpio-keys instead as > suggested by Cory Maccarrone <darkstar6262@xxxxxxxxx> and > Janusz Krzysztofik <jkrzyszt@xxxxxxxxxxxx>. > > Cc: Cory Maccarrone <darkstar6262@xxxxxxxxx> > Cc: Janusz Krzysztofik <jkrzyszt@xxxxxxxxxxxx> > Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx> > <<snip>> -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html