RE: [PATCH] Correct definition of register of OMAP4_RM_RSTST and OMAP4_RM_RSTTIME

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap-
> owner@xxxxxxxxxxxxxxx] On Behalf Of MING ZHOU
> Sent: Tuesday, December 07, 2010 1:04 PM
> To: linux-omap@xxxxxxxxxxxxxxx
> Cc: Tony Lindgren; Paul Walmsley
> Subject: [PATCH] Correct definition of register of OMAP4_RM_RSTST and
> OMAP4_RM_RSTTIME
>
> Since we need to reconfigure Reset time for OMAP4, we found the OMAP4
> register definition for reset time is wrong according to spec of
> OMAP4. And we verified this by reading default value of register. We
> found the offset definition of Reset time and Reset Test register
> should be switched. After correcting this bug, we verified by changing
> the value of reset time register, the pulse generated for reset is
> also changed as expected on scope.
>
> From 9a9c98c2f4008e5d8f2f5da1101e3bfe222a48ed Mon Sep 17 00:00:00 2001
> From: Zhou Ming <a17711@xxxxxxxxxxxx>
> Date: Tue, 7 Dec 2010 10:00:59 -0500
> Subject: [PATCH] Correct definition of register of OMAP4_RM_RSTST and
> OMAP4_RM_RSTTIME
>
> According to test result, we found the offset definition of
OMAP4_RM_RSTST
> and OMAP4_RM_RSTIME should be switched.
> ---
>  arch/arm/mach-omap2/prm.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/prm.h b/arch/arm/mach-omap2/prm.h
> index 7be040b..23b4be2 100644
> --- a/arch/arm/mach-omap2/prm.h
> +++ b/arch/arm/mach-omap2/prm.h
> @@ -222,8 +222,8 @@
>
>  /* Omap4 specific registers */
>  #define OMAP4_RM_RSTCTRL                               0x0000
> -#define OMAP4_RM_RSTTIME                               0x0004
> -#define OMAP4_RM_RSTST                                 0x0008
> +#define OMAP4_RM_RSTTIME                               0x0008
> +#define OMAP4_RM_RSTST                                 0x0004
Yep. This is indeed correct offsets.

>  #define OMAP4_PM_PWSTCTRL                              0x0000
>  #define OMAP4_PM_PWSTST                                        0x0004
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux