On 6 December 2010 17:35, Dave Martin <dave.martin@xxxxxxxxxx> wrote: > Â* Explicitly build a few parts of sleep34xx.S as ARM. > > Â Â Â* lock_scratchpad_sem is kept as ARM because of the need to > Â Â Â Âsynchronise with hardware (?) using the SWP instruction. > > Â Â Â* save_secure_ram_context and omap34xx_cpu_suspend are built > Â Â Â Âas ARM in case the Secure World firmware expects to decode > Â Â Â Âthe comment field from the SMC (aka smi) instructions. > > Â Â Â ÂThis can be undone later if the firmware is confirmed as > Â Â Â Âable to decode the Thumb SMC encoding (or ignores the > Â Â Â Âcomment field). > > Â Â Â* es3_sdrc_fix should presumably only be called from the > Â Â Â Âlow-level wakeup code. ÂTo minimise the diff, switched this > Â Â Â Âto ARM and demoted it to be a local symbol, since I believe > Â Â Â Âit shouldn't be called from outside anyway. I haven't checked the code but does this always work? The kernel isn't built with interworking enabled, so it's either ARM or Thumb-2. -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
