* srinath@xxxxxxxxxxxxxxxxxxxx <srinath@xxxxxxxxxxxxxxxxxxxx> [2010-12-01 22:28:50 +0530]: > From: Srinath <srinath@xxxxxxxxxxxxxxxxxxxx> > > AM3517/05 Craneboard has one EHCI interface on board using port1. > > GPIO35 is used as power enable. > GPIO38 is used as port1 PHY reset. > > History: > http://marc.info/?l=linux-omap&w=2&r=1&s=Craneboard%3A+Add+USB+EHCI+support&q=t > > Signed-off-by: Srinath <srinath@xxxxxxxxxxxxxxxxxxxx> > --- > arch/arm/mach-omap2/board-am3517crane.c | 40 +++++++++++++++++++++++++++++++ > 1 files changed, 40 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/board-am3517crane.c b/arch/arm/mach-omap2/board-am3517crane.c > index 13ead33..6fd5dfe 100644 > --- a/arch/arm/mach-omap2/board-am3517crane.c > +++ b/arch/arm/mach-omap2/board-am3517crane.c > @@ -28,8 +28,13 @@ > [...] > static void __init am3517_crane_init(void) > { > + int ret; > + > omap3_mux_init(board_mux, OMAP_PACKAGE_CBB); > omap_serial_init(); > + > + /* Configure GPIO for EHCI port */ > + omap_mux_init_gpio(GPIO_USB_POWER, OMAP_PIN_OUTPUT); This is non void function. You can consider return value for further processing. > + > + ret = gpio_request(GPIO_USB_POWER, "usb_ehci_enable"); > + if (ret < 0) { > + pr_err("Cannot request GPIO %d\n", GPIO_USB_POWER); > + return; > + } > + > + ret = gpio_direction_output(GPIO_USB_POWER, 1); > + if (ret < 0) > + goto err; > + > + omap_mux_init_gpio(GPIO_USB_NRESET, OMAP_PIN_OUTPUT); -Ditto- Also, why there is no gpio_request for "GPIO_USB_NRESET" -Manjunath [...] -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
