Mayuresh,
One minor comment below.
On Wed, Dec 1, 2010 at 16:29, Janorkar, Mayuresh <mayur@xxxxxx> wrote:
> From: Mayuresh Janorkar <mayur@xxxxxx>
>
> This patch would add two APIs for panel-taal:
> check_timings and set_timings.
>
> These are required by omapfb in case we wish to set default mode through bootargs.
> e.g.: omapfb.mode="lcd:640x480-16" (display device:width X height - bits per pixel)
>
> omapfb_set_def_mode function in omapfb-main.c essentially needs these functions
> otherwise it would return -EINVAL and default mode sent through bootargs
> would be ignored.
>
> Signed-off-by: Mayuresh Janorkar <mayur@xxxxxx>
> ---
> drivers/video/omap2/displays/panel-taal.c | 25 +++++++++++++++++++++++++
> 1 files changed, 25 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/video/omap2/displays/panel-taal.c b/drivers/video/omap2/displays/panel-taal.c
> index e1c765d..e29c308 100644
> --- a/drivers/video/omap2/displays/panel-taal.c
> +++ b/drivers/video/omap2/displays/panel-taal.c
> @@ -476,6 +476,29 @@ static void taal_get_timings(struct omap_dss_device *dssdev,
> *timings = dssdev->panel.timings;
> }
>
> +static void taal_set_timings(struct omap_dss_device *dssdev,
> + struct omap_video_timings *timings)
> +{
> + /* TAAL panel's timing struct has only x_res and y_res
> + * other timing parameters are not set
> + */
Check multi-line comment style
> + dssdev->panel.timings.x_res = timings->x_res;
> + dssdev->panel.timings.y_res = timings->y_res;
> +}
> +
> +static int taal_check_timings(struct omap_dss_device *dssdev,
> + struct omap_video_timings *timings)
> +{
> + /* TAAL panel's timing struct has only x_res and y_res
> + * other timing parameters are not set
> + */
Ditto
> + if (!timings || timings->x_res != dssdev->panel.timings.x_res ||
> + timings->y_res != dssdev->panel.timings.y_res)
> + return -EINVAL;
> +
> + return 0;
> +}
> +
> static void taal_get_resolution(struct omap_dss_device *dssdev,
> u16 *xres, u16 *yres)
> {
> @@ -1563,6 +1586,8 @@ static struct omap_dss_driver taal_driver = {
> .memory_read = taal_memory_read,
>
> .get_timings = taal_get_timings,
> + .set_timings = taal_set_timings,
> + .check_timings = taal_check_timings,
>
> .driver = {
> .name = "taal",
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
