On 11/25/2010 09:58 AM, Hemanth V wrote: > ----- Original Message ----- > From: "Gregory CLEMENT" <gregory.clement@xxxxxxxxxxxxxxxxxx> > To: "linux-omap" <linux-omap@xxxxxxxxxxxxxxx>; > <spi-devel-general@xxxxxxxxxxxxxxxxxxxxx> > Cc: "David Brownell" <dbrownell@xxxxxxxxxxxxxxxxxxxxx>; "Grant Likely" > <grant.likely@xxxxxxxxxxxx>; "Kevin Hilman" <khilman@xxxxxxxxxxxxxxxxxxx> > Sent: Thursday, November 25, 2010 3:49 AM > Subject: [PATCH v5 1/1] OMAP2: Spi: Force CS to be in inactive state after > off-mode transition > > >> As request by Grant Likely, there is no more cover letter. Full changelog >> is following. >> I am still reluctant to add this changelog in the patch description, as it >> adds no value to >> the patch itself: when it was needed I try to updat comments or patch >> description. >> I understand that Grant Likely would need an ack from other user as this >> patch fix a corner case. >> Kevin Hilman made a few comments on this patch so he could add his "Ack >> by" or at least his "Review by". >> > > I was trying to run some tests with this patch. I find that the resume > function registered by this patch doesnot seem to > get called during system wide suspend/resume, since spi_resume only calls > the resume routine registered by spi client driver. > Is there something I am missing. In fact the resume function for this driver won't be called by spi bus but by platform bus. Indeed this function is registered in a platform_driver structure. > > Thanks > Hemanth > > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html