Hi Ohad,
On Tue, 2010-11-23 at 17:38 +0200, Ohad Ben-Cohen wrote:
> From: Simon Que <sque@xxxxxx>
>
> Add hwspinlock support for the OMAP4 Hardware Spinlock device.
>
<snip>
> +
> + io_base = ioremap(res->start, resource_size(res));
> + if (!io_base) {
> + ret = -ENOMEM;
> + goto free_state;
> + }
> +
> + /* Determine number of locks */
> + i = readl(io_base + SYSSTATUS_OFFSET);
> + i >>= SPINLOCK_NUMLOCKS_BIT_OFFSET;
> +
> + /* exactly one of the four least significant bits must be 1 */
> + if (!i || !is_power_of_2(i) || i > 8) {
> + ret = -EINVAL;
> + goto iounmap_base;
> + }
> +
At iounmap_base you unmap state->io_base, but that's set only after this
check. You should probably iounmap(io_base).
Regards,
Ionut.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
