On Mon, 22 Nov 2010 17:48:24 -0700 (MST) Paul Walmsley <paul@xxxxxxxxx> wrote: > > Signed-off-by: Janusz Krzysztofik <jkrzyszt@xxxxxxxxxxxx> > > Thanks for fixing this. What do you think about the following patch > instead? It should avoid any compiler issues. > Hmm.. looks like Janusz's patch is still in Liam's for-2.6.37 branch only. > +/* > + * The following functions are only required on an OMAP1-only build. > + * mach-omap2/mcbsp.c contains the real functions > + */ > +#ifndef CONFIG_ARCH_OMAP2PLUS > +int omap2_mcbsp_set_clks_src(u8 id, u8 fck_src_id) > +{ Would that create a new problem if we are able to compile some day omap1 and omap2 support into same kernel? I agree with you that passing these via platform_data sounds the right solution. -- Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html