Nishanth Menon <nm@xxxxxx> writes: > This patch adds OPP tables for OMAP4. New file has been added to keep > the OMAP4 opp tables and the registration of these tables with the > generic opp framework by OMAP SoC OPP interface. [...] > diff --git a/arch/arm/mach-omap2/opp.c b/arch/arm/mach-omap2/opp.c > index 66e12be..48a553f 100644 > --- a/arch/arm/mach-omap2/opp.c > +++ b/arch/arm/mach-omap2/opp.c > @@ -131,4 +131,5 @@ static int __init omap_init_opp_table(struct omap_opp_def *opp_def, > > /* omap3 opps */ > #include "opp3xxx_data.c" > - > +/* omap4 opps */ > +#include "opp4xxx_data.c" I'm not sure I like the including of C files. Any reason you prefer this to just adding them to the Makefile? e.g. opp24xx_dta.c are compiled in via Makefile and these two are included. I vote for consistency. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html