Hi Sergei, Thanks for review, I will modify and resend patch. With Regards Srinath -----Original Message----- From: Sergei Shtylyov [mailto:sshtylyov@xxxxxxxxxx] Sent: Saturday, November 20, 2010 5:09 PM To: srinath@xxxxxxxxxxxxxxxxxxxx Cc: linux-omap@xxxxxxxxxxxxxxx; nm@xxxxxx; linux@xxxxxxxxxxxxxxxx; umeshk@xxxxxxxxxxxxxxxxxxxx; tony@xxxxxxxxxxx; nagendra@xxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; khilman@xxxxxxxxxxxxxxxxxxx; jdk@xxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx Subject: Re: [Patch v1] AM35xx: Craneboard: Add USB EHCI support Hello. On 19-11-2010 19:07, srinath@xxxxxxxxxxxxxxxxxxxx wrote: > From: Srinath<srinath@xxxxxxxxxxxxxxxxxxxx> > AM3517/05 Craneboard has one EHCI interface on board using port1. > GPIO35 is used as power enable. > GPIO38 is used as port1 PHY reset. > Signed-off-by: Srinath<srinath@xxxxxxxxxxxxxxxxxxxx> > --- > arch/arm/mach-omap2/board-am3517crane.c | 21 +++++++++++++++++++++ > 1 files changed, 21 insertions(+), 0 deletions(-) > diff --git a/arch/arm/mach-omap2/board-am3517crane.c b/arch/arm/mach-omap2/board-am3517crane.c > index 13ead33..0e1a806 100644 > --- a/arch/arm/mach-omap2/board-am3517crane.c > +++ b/arch/arm/mach-omap2/board-am3517crane.c [...] > @@ -53,10 +55,29 @@ static void __init am3517_crane_init_irq(void) > omap_gpio_init(); > } > > +static struct ehci_hcd_omap_platform_data ehci_pdata __initdata = { > + .port_mode[0] = EHCI_HCD_OMAP_MODE_PHY, > + .port_mode[1] = EHCI_HCD_OMAP_MODE_UNKNOWN, > + .port_mode[2] = EHCI_HCD_OMAP_MODE_UNKNOWN, > + > + .phy_reset = true, > + .reset_gpio_port[0] = 38, > + .reset_gpio_port[1] = -EINVAL, > + .reset_gpio_port[2] = -EINVAL > +}; > + > static void __init am3517_crane_init(void) > { > omap3_mux_init(board_mux, OMAP_PACKAGE_CBB); > omap_serial_init(); > + > + /* Configure GPIO for EHCI port */ > + omap_mux_init_gpio(35, OMAP_PIN_OUTPUT); > + gpio_request(35, "usb_ehci_enable"); > + gpio_direction_output(35, 1); > + gpio_set_value(35, 1); There's no need to call gpio_set_value(), as gpio_direction_output() has already set the GPIO's value. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
