> -----Original Message----- > From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- > owner@xxxxxxxxxxxxxxx] On Behalf Of Nishanth Menon > Sent: Saturday, November 20, 2010 3:07 AM > To: Kevin Hilman > Cc: linux-omap; Jean Pihet; Vishwanath Sripathy; Tony > Subject: Re: [PATCH 00/13] OMAP3: OFF mode fixes > > Kevin Hilman had written, on 11/19/2010 03:20 PM, the following: > > >> Request for testing this series for comparison between master and this > >> series requested for additional platforms where available. > > > > I haven't yet been through the entire series, but some general comments > > to share before the weekend: > thanks for comments so far. I will wait for the complete series to be > reviewed before reposting a v2. > > > > > The secure mode code is growing in size and complexity, so I think it > > should be removed from pm34xx.c and moved into it's own file > > (secure3xxx.c ?) This will help keep pm34xx.c lean, and it can call > > into secure code as needed. We already have omap44xx-smc.S. I could make this generic. One problem with The secure APIs, they are consistent in all OMAP version. For example Secure SAR save has a different API and signature on OMAP3 and OMAP4. But this is something doable. Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
