Kevin Hilman had written, on 11/19/2010 01:47 PM, the following:
Nishanth Menon <nm@xxxxxx> writes:
Kevin Hilman had written, on 11/19/2010 11:15 AM, the following:
Nishanth Menon <nm@xxxxxx> writes:
From: Eduardo Valentin <eduardo.valentin@xxxxxxxxx>
We need to disable the autoidle bit from MPU INTC,
otherwise INTC would get stall, and we would never
come out of WFI. This must be done before save secure ram
as well because save secure ram also does WFI.
This patch is just a addition to the current W/A we have for i540,
in order to cover the WFI inside the save secure ram.
This 'in addition' doesn't really make sense to me. This doesn't add
anything to the current workaround, it just changes the order of
operations.
yes - the "in addition" part is as follows:
ideally speaking you just need the omap3_intc_prepare_idle just before
wfi. we "in addition" need to protect the save_secure_ram call as well
because ROM code's WFI hits the same window of the bug that we do in
the kernel. I believe the "in addition" was meant to state that we
have to protect the logic of romcode as well..
OK, then it needs to be rephrased. It doesn't need to (re)summarize the
i540 workaround, since it's already in the kernel. You could just state:
The existing workaround for erratum i540 (disable MPU INTC auto-idle)
needs to be done before saving secure RAM since secure-mode call can
also do WFI.
yep, Thanks, this is indeed a better description - will take it in as
part of my v2.
--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
