Re: [PATCH] omap: nand: remove hardware ECC as default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 18, 2010 at 8:01 PM, Tony Lindgren <tony@xxxxxxxxxxx> wrote:
> * Sukumar Ghorai <s-ghorai@xxxxxx> [101118 06:12]:
>> CONFIG_MTD_NAND_OMAP_HWECC defined wronly in patch submitted during 2.6.36
>> that using the hardware ECC by default

wrongly

>>
>> Signed-off-by: Sukumar Ghorai <s-ghorai@xxxxxx>
>> ---
>>  drivers/mtd/nand/omap2.c |    1 -
>>  1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
>> index cd41c58..15682ec 100644
>> --- a/drivers/mtd/nand/omap2.c
>> +++ b/drivers/mtd/nand/omap2.c
>> @@ -7,7 +7,6 @@
>>   * it under the terms of the GNU General Public License version 2 as
>>   * published by the Free Software Foundation.
>>   */
>> -#define CONFIG_MTD_NAND_OMAP_HWECC
>>
>>  #include <linux/platform_device.h>
>>  #include <linux/dma-mapping.h>
>
> This looks like a fix for the -rc cycle. Can you please update
> the description a bit to specify which commit broke it and
> what the error is now?

Well it broke NAND for beagle and pandora at least, as those have been
using sw ecc, all IO simply results in ECC errors with that define.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux