NIshant, On Thu, Nov 18, 2010 at 8:27 PM, Nishanth Menon <nm@xxxxxx> wrote: >> -----Original Message----- >> From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- >> owner@xxxxxxxxxxxxxxx] On Behalf Of Jean Pihet >> Sent: Thursday, November 18, 2010 8:52 AM >> To: linux-omap@xxxxxxxxxxxxxxx >> Cc: Vishwanath BS; Kevin Hillman; Jean Pihet >> Subject: [PATCH 1/2] OMAP3 PM: move omap3 sleep to ddr >> >> From: Vishwanath BS <vishwanath.bs@xxxxxx> >> >> For historical reasons the OMAP3 sleep code is run from SRAM. >> This code can run from DDR which provides better performance and >> leaves the SRAM available for other uses. >> >> Tested on ZOOM3, OMAP3EVM, Beagleboard, n900 >> with full RET and OFF modes. > > Sorry, But I disagree with this patch. > > There is a silicon errata which cannot be handled with this - RTA disable > - errata i608 > > You need to disable RTA while coming out of OFF - we cannot handle this on > > GP devices if this is not done. When you come out of Core off, SRAM contents are anyway lost. So you have to run from DDR after ROM Code completes. This behavior has not changed with this patch. I fail to understand your concern here. Vishwa > >> >> Signed-off-by: Vishwanath BS <vishwanath.bs@xxxxxx> >> Cc: Kevin Hillman <khilman@xxxxxxxxxxxxxxxxxxx> >> >> Changed the commit comments. >> >> Cc: Jean Pihet <j-pihet@xxxxxx> >> --- >> arch/arm/mach-omap2/pm34xx.c | 9 +-------- >> 1 files changed, 1 insertions(+), 8 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c >> index 75c0cd1..035ca47 100644 >> --- a/arch/arm/mach-omap2/pm34xx.c >> +++ b/arch/arm/mach-omap2/pm34xx.c >> @@ -65,8 +65,6 @@ struct power_state { >> >> static LIST_HEAD(pwrst_list); >> >> -static void (*_omap_sram_idle)(u32 *addr, int save_state); >> - >> static int (*_omap_save_secure_sram)(u32 *addr); >> >> static struct powerdomain *mpu_pwrdm, *neon_pwrdm; >> @@ -346,9 +344,6 @@ void omap_sram_idle(void) >> int core_prev_state, per_prev_state; >> u32 sdrc_pwr = 0; >> >> - if (!_omap_sram_idle) >> - return; >> - >> pwrdm_clear_all_prev_pwrst(mpu_pwrdm); >> pwrdm_clear_all_prev_pwrst(neon_pwrdm); >> pwrdm_clear_all_prev_pwrst(core_pwrdm); >> @@ -422,7 +417,7 @@ void omap_sram_idle(void) >> * get saved. The restore path then reads from this >> * location and restores them back. >> */ >> - _omap_sram_idle(omap3_arm_context, save_state); >> + omap34xx_cpu_suspend(omap3_arm_context, save_state); >> cpu_init(); >> >> /* Restore normal SDRC POWER settings */ >> @@ -972,8 +967,6 @@ static int __init clkdms_setup(struct clockdomain >> *clkdm, void *unused) >> >> void omap_push_sram_idle(void) >> { >> - _omap_sram_idle = omap_sram_push(omap34xx_cpu_suspend, >> - omap34xx_cpu_suspend_sz); >> if (omap_type() != OMAP2_DEVICE_TYPE_GP) >> _omap_save_secure_sram = >> omap_sram_push(save_secure_ram_context, >> save_secure_ram_context_sz); >> -- >> 1.7.2.3 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-omap" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
